Unity 8

Code review comment for lp:~mzanetti/unity8/unified-stages

  1. unified-stages
  2. Merge into trunk
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

In qml/Stage/Stage.qml:

"""
        readonly property real virtualKeyboardHeight: SurfaceManager.inputMethodSurface
                                                          ? SurfaceManager.inputMethodSurface.inputBounds.height
                                                          : 0
"""

Please get it from outside. Let Shell wire it to inputMethod.visibleRect.height

"""
                    when: root.oskEnabled && appDelegate.focus && (appDelegate.state == "normal" || appDelegate.state == "restored")
                          && SurfaceManager.inputMethodSurface
                          && SurfaceManager.inputMethodSurface.state != Mir.HiddenState
                          && SurfaceManager.inputMethodSurface.state != Mir.MinimizedState
""""

Likewise, all these SurfaceManager expressions could be supplied by inputMethod.visible from Shell.qml

« Back to merge proposal