Code review comment for lp:~mzanetti/unity8/right-edge-2

Revision history for this message
Gerry Boland (gerboland) wrote :

+++ qml/Stages/TransformedSpreadDelegate.qml

Since this relies heavily on the animation "stages" reported by the spreadView, a comment explaining the different behaviours of the tile in each stage (mentioning the position markers) would help a lot.

+ property real animatedProgress: 0
purpose not obvious to me how it's different to "progress", add comment please

+ property real tile1StartScale: startScale + .4
+ property real tile0SnapAngle: 10
could be made readonly, or private actually.

+ priv.stage2startTranslate = priv.easingAnimation(0, spreadView.positionMarker4, 0, -spreadView.width, spreadView.positionMarker4) + spreadView.width;
confuses me, why the -spreadView.width offset for the animation?

+ // As they are static values, lets caluclate
typo

+ property real xTranslate: {
in many of the calculations in this block, there's a "-spreadView.width" being used in the calculation of the start or end value in a linearAnimation. Could you add a note justifying it?

+ return linearAnimation(selectedProgress, negativeProgress, selectedXTranslate, selectedXTranslate - spreadView.tileDistance, root.progress);
please wrap

+ } else if(spreadView.stage == 1) {
space needed after "if"

« Back to merge proposal