Code review comment for lp:~mzanetti/unity8/right-edge-2

Revision history for this message
Gerry Boland (gerboland) wrote :

+++ qml/Stages/SwitchingApplicationImage.qml
+ onApplicationChanged: print("setting app to", application.appId, application.screenshot)
debug info necessary?

+ signal switched()
I prefer roughly sticking to the guidelines (http://qt-project.org/doc/qt-4.8/qml-coding-conventions.html) and declaring signals after properties, but before javascript function definitions

+ Image {
+ visible: true
should not be necessary

You have a couple of commented out lines in this file too, please remove them.

« Back to merge proposal