Code review comment for lp:~mzanetti/unity8/right-edge-2

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> 10. Starting Gallery app does not make panel hide (which it should)

Fixed.

>
> 11. Quick right edge swipe can be a little flickery. I'd forgive this however,
> I know what's going on.

Hmm... seems to work perfectly fine here... But I guess if you flick really quick and the device is busy otherwise you might manage to see some screenshot updating action.

>
> 12. With multiple apps open, bring up the OSK somehow. Then do right edge
> swipe to show spread. OSK stuck open

Yeah... that's a bit of an issue. Right now there's no way to hide the OSK except unfocing the app. As that causes the whole state machine to update it causes effects like the panel coming in for half a second (you you transition from fullscreen to fullscreen) and some more such issues. Changing the code to deal with that would be quite intrusive and afaik the plan is to make the OSK part of the app surface anyways. Can we ignore this for this merge?

« Back to merge proposal