Merge lp:~mzanetti/unity8/quicklist-unset-model-before-closing into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 240
Merged at revision: 256
Proposed branch: lp:~mzanetti/unity8/quicklist-unset-model-before-closing
Merge into: lp:unity8
Prerequisite: lp:~mzanetti/unity8/theme-quicklist
Diff against target: 24 lines (+5/-1)
1 file modified
Launcher/LauncherPanel.qml (+5/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/quicklist-unset-model-before-closing
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Approve
Michał Sawicz Approve
Review via email: mp+181517@code.launchpad.net

Commit message

unset model in quicklist before closing it

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
240. By Michael Zanetti

merge trunk

Revision history for this message
Albert Astals Cid (aacid) wrote :

Ok :-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Launcher/LauncherPanel.qml'
--- Launcher/LauncherPanel.qml 2013-08-26 23:35:13 +0000
+++ Launcher/LauncherPanel.qml 2013-08-27 07:02:25 +0000
@@ -492,6 +492,7 @@
492 height: childrenRect.height492 height: childrenRect.height
493493
494 Repeater {494 Repeater {
495 id: popoverRepeater
495 model: popover.model496 model: popover.model
496497
497 ListItems.Standard {498 ListItems.Standard {
@@ -502,8 +503,11 @@
502 if (!model.clickable) {503 if (!model.clickable) {
503 return;504 return;
504 }505 }
506 PopupUtils.close(popover);
507 // Unsetting model to prevent showing changing entries during fading out
508 // that may happen because of triggering an action.
505 LauncherModel.quickListActionInvoked(appId, index);509 LauncherModel.quickListActionInvoked(appId, index);
506 PopupUtils.close(popover);510 popoverRepeater.model = undefined;
507 }511 }
508 }512 }
509 }513 }

Subscribers

People subscribed via source and target branches