Unity 8

Merge lp:~mzanetti/unity8/quicklist-unset-model-before-closing into lp:unity8

  1. quicklist-unset-model-before-closing
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 240
Merged at revision: 256
Proposed branch: lp:~mzanetti/unity8/quicklist-unset-model-before-closing
Merge into: lp:unity8
Prerequisite: lp:~mzanetti/unity8/theme-quicklist
Diff against target: 24 lines (+5/-1)
1 file modified
Launcher/LauncherPanel.qml (+5/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/quicklist-unset-model-before-closing
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Approve
Michał Sawicz Approve
Review via email: mp+181517@code.launchpad.net

Commit message

unset model in quicklist before closing it

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:237
http://jenkins.qa.ubuntu.com/job/unity8-ci/723/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2486/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/145/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1230
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/724/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/723/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2492/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/147/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/723/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/309/
Executed test runs:
    None: http://s-jenkins:8080/job/generic-cleanup-mbs/1780/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2651/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/278/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1350/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/308/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/309/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2657/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/280/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:239
http://jenkins.qa.ubuntu.com/job/unity8-ci/782/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2653/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/280/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1352/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/783/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/782/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2659/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/282/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/782/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/318/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/1794/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2661/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/288/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1360/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/317/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/318/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2667/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/290/console

review: Needs Fixing (continuous-integration)
lp:~mzanetti/unity8/quicklist-unset-model-before-closing updated
240. By Michael Zanetti

merge trunk

Revision history for this message
Albert Astals Cid (aacid) wrote :

Ok :-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:240
http://jenkins.qa.ubuntu.com/job/unity8-ci/783/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2664
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/291
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1362
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/784
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/784/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/783
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2670
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2670/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2256
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/293
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/293/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/261
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/264

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/783/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Launcher/LauncherPanel.qml'
2--- Launcher/LauncherPanel.qml 2013-08-26 23:35:13 +0000
3+++ Launcher/LauncherPanel.qml 2013-08-27 07:02:25 +0000
4@@ -492,6 +492,7 @@
5 height: childrenRect.height
6
7 Repeater {
8+ id: popoverRepeater
9 model: popover.model
10
11 ListItems.Standard {
12@@ -502,8 +503,11 @@
13 if (!model.clickable) {
14 return;
15 }
16+ PopupUtils.close(popover);
17+ // Unsetting model to prevent showing changing entries during fading out
18+ // that may happen because of triggering an action.
19 LauncherModel.quickListActionInvoked(appId, index);
20- PopupUtils.close(popover);
21+ popoverRepeater.model = undefined;
22 }
23 }
24 }

Subscribers

People subscribed via source and target branches