Code review comment for lp:~mzanetti/unity8/launcher-surfaceCount-pips

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Here I use surfaceList::count instead of application::surfaceCount and got no crashes (both on phone and laptop):
http://bazaar.launchpad.net/~dandrader/unity8/launcher-surfaceCount-pips/revision/2398

As the documentation says about sender(), "This function violates the object-oriented principle of modularity.", even if you're using it correctly.

I've been using lambdas extensively with Qt signal/slot connections for a while now and they're working fine.

I still think Application::surfaceCount is redundant.

A side comment: regardless of whether you use lambdas and surfaceList::count or not, in LauncherModel::applicationRemoved you should disconnect what you connected in LauncherModel::applicationAdded.

review: Needs Fixing

« Back to merge proposal