Merge lp:~mzanetti/unity8/launcher-new-count-emblem into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 1048
Merged at revision: 1100
Proposed branch: lp:~mzanetti/unity8/launcher-new-count-emblem
Merge into: lp:unity8
Diff against target: 54 lines (+9/-11)
2 files modified
qml/Launcher/LauncherDelegate.qml (+9/-6)
qml/Launcher/graphics/notification@30.sci (+0/-5)
To merge this branch: bzr merge lp:~mzanetti/unity8/launcher-new-count-emblem
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Cimitan (community) Approve
Vesa Rautiainen (community) design Approve
Review via email: mp+226998@code.launchpad.net

Commit message

update launcher count emblems to match new spec

Description of the change

Screenshot for easier design review: http://i.imgur.com/bqTxKQx.png

* Are there any related MPs required for this MP to build/function as expected? Please list.

No

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

 * Did you make sure that your branch does not contain spurious tags?

Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

 * If you changed the UI, has there been a design review?

requested in here

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Vesa Rautiainen (vesar) :
review: Approve (design)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
1047. By Michael Zanetti

some tweaks requested by the reviewer

1048. By Michael Zanetti

add fixme

Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/Launcher/LauncherDelegate.qml'
--- qml/Launcher/LauncherDelegate.qml 2014-07-09 19:45:23 +0000
+++ qml/Launcher/LauncherDelegate.qml 2014-07-29 10:22:56 +0000
@@ -70,28 +70,31 @@
70 height: root.itemHeight - units.gu(1)70 height: root.itemHeight - units.gu(1)
71 }71 }
7272
73 BorderImage {73 UbuntuShape {
74 objectName: "countEmblem"74 objectName: "countEmblem"
75 anchors {75 anchors {
76 right: parent.right76 right: parent.right
77 top: parent.top77 top: parent.top
78 margins: units.dp(3)78 margins: units.dp(3)
79 }79 }
80 width: Math.min(root.itemWidth, Math.max(units.gu(3), countLabel.implicitWidth + units.gu(2.5)))80 width: Math.min(root.itemWidth, Math.max(units.gu(2), countLabel.implicitWidth + units.gu(1)))
81 height: units.gu(3)81 height: units.gu(2)
82 source: "graphics/notification.sci"82 color: UbuntuColors.orange
83 visible: root.count > 083 visible: root.count > 0
84 borderSource: "none"
8485
85 Label {86 Label {
86 id: countLabel87 id: countLabel
87 text: root.count88 text: root.count
88 anchors.centerIn: parent89 anchors.centerIn: parent
90 // FIXME: verticalCenter seems to be off wee bit and QML doesn't have a centerLine
91 // property for Text: https://bugreports.qt-project.org/browse/QTBUG-40479
92 anchors.verticalCenterOffset: -units.dp(.5)
89 width: root.itemWidth - units.gu(1)93 width: root.itemWidth - units.gu(1)
90 horizontalAlignment: Text.AlignHCenter94 horizontalAlignment: Text.AlignHCenter
91 elide: Text.ElideRight95 elide: Text.ElideRight
92 color: "white"96 color: "white"
93 fontSize: "small"97 fontSize: "x-small"
94 font.bold: true
95 }98 }
96 }99 }
97100
98101
=== removed file 'qml/Launcher/graphics/notification@30.png'
99Binary files qml/Launcher/graphics/notification@30.png 2013-08-19 19:34:03 +0000 and qml/Launcher/graphics/notification@30.png 1970-01-01 00:00:00 +0000 differ102Binary files qml/Launcher/graphics/notification@30.png 2013-08-19 19:34:03 +0000 and qml/Launcher/graphics/notification@30.png 1970-01-01 00:00:00 +0000 differ
=== removed file 'qml/Launcher/graphics/notification@30.sci'
--- qml/Launcher/graphics/notification@30.sci 2013-08-19 19:34:03 +0000
+++ qml/Launcher/graphics/notification@30.sci 1970-01-01 00:00:00 +0000
@@ -1,5 +0,0 @@
1border.left: 36
2border.top: 36
3border.bottom: 36
4border.right: 36
5source: notification@30.png
6\ No newline at end of file0\ No newline at end of file

Subscribers

People subscribed via source and target branches