Code review comment for lp:~mzanetti/unity8/fix-preview-collapsing
Revision history for this message
| Michael Zanetti (mzanetti) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> I'm not entirely sure of that solution... Reaching down into the views for
> that sounds bad. I think I'd rather go for a signal that the views would
> connect to, WTYT?
Fair point. Will change... we actually already have that signal.
>
> Why the change onScreen change, btw?
onScreen is internally used to keep the preview loaded while the collapsing animation happens. On the outside, this is used to determine if a preview is open in order to block the swiping left/right. I did the change to be able to set it from the outside as we can't do that with onScreen. That doesn't really care if it's onScreen or just open. Anyways, with the new, upcoming solution this isn't needed any more and I reverted it back to onScreen as that seems slightly cleaner. Additionally I made it readonly because it doesn't allow setting it from the outside.