Code review comment for lp:~mzanetti/unity8/edge-hinting-tweaks

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> > function test_tease(data) {
>
> That's a very inclusive name (could include even test_teasingArea). But what
> you're testing there is much more specific. You're testing the interaction
> between greeter being locked and its tease animation. If later you add a test
> about something else involving the tease animation you might have to rename
> this one. So I would call it like test_noTeaseIfLocked or test_teaseVsLock.
> Including a comment explaining what the test wanna check also wouldn't hurt
> (tests/qmltests/README!) but it's perfectly fine if you don't (test is rather
> small after all).
>

Yep. I agree on this. I used test_tease mainly because test_teasingArea was already there, which checks if both teasingAreas work. As this one really does a tease, I named it lake that. Anyways, you're absolutely right on this and I renamed it to test_teaseLockedUnlocked().

« Back to merge proposal