Code review comment for lp:~mzanetti/unity8/edge-hinting-tweaks

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> function test_tease(data) {

That's a very inclusive name (could include even test_teasingArea). But what you're testing there is much more specific. You're testing the interaction between greeter being locked and its tease animation. If later you add a test about something else involving the tease animation you might have to rename this one. So I would call it like test_noTeaseIfLocked or test_teaseVsLock. Including a comment explaining what the test wanna check also wouldn't hurt (tests/qmltests/README!) but it's perfectly fine if you don't (test is rather small after all).

But I won't insist if you wanna keep it like that. It's already good as it is.

review: Approve

« Back to merge proposal