Code review comment for lp:~mzanetti/unity8/edge-hinting-tweaks

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> tst_Launcher.qml:159
> tryCompareFunction(function(){return launcher.maxPanelX >=
> -launcher.panelWidth + units.gu(2) - 2;}, true)
>
> That's 122 chars long. Our coding style sets a limit of 120 (hmm, I'm starting
> to think we should have an automatic checker for that, like we do for the
> whitespace)

now it looks like shit and did not contribute to readability the smallest bit, but as long as the guideline is happy...

done

« Back to merge proposal