Code review comment for lp:~mzanetti/unity8/dnd-and-quicklists

> I wonder if invoking dnd should be disabled on folded icons? Otherwise:
> * when two items are folded and you long press the bottom one, the one on top
> of it will be used

Disabled dragging of items with an angle > 20 degrees

> * there's no unfolding animation visible when invoking d'n'd on a folded icon

Added an animation when starting dragging

>
> Dropping at the top still results in some jumping.

Should be gone now. The last issue, that the top/bottom dropped items are still slightly folded is the Qt bug we're trying to fix.

>
> Weren't "other" launcher items supposed to dim on long press? They only dim
> onDrag now, somewhat tricky to see that it's "now" if only the item under your
> finger changes.

Nope, according to Martin's design they should only be dimmed once a dnd operation starts. I agree that its a bit hard to see if the finger covers the current item. However, this will improve once the quicklists are back because that one appears immediately on longpress and goes away the same time the other icons dim.

>
> Sometimes I end up with an empty space the size of an item that... Sometimes
> moves around, sometimes not. Dragging *inside* the launcher seems to be the
> easiest to reproduce.

Yes. I fear this is a Qt bug. Need to discuss this with Albert. If you make the window a bit smaller, and then drag into the progressiveScrollingarea you'll see that newly created delegates are positioned correctly. Seems like _sometimes_ the displace animation fails to start.

>
> I'd be OK with merging this if you say these should be fixed at a later
> iteration, though.

afaics only the Qt bugs left.