Code review comment for lp:~mzanetti/unity8/dnd-and-quicklists

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

I wonder if invoking dnd should be disabled on folded icons? Otherwise:
* when two items are folded and you long press the bottom one, the one on top of it will be used
* there's no unfolding animation visible when invoking d'n'd on a folded icon

Dropping at the top still results in some jumping.

Weren't "other" launcher items supposed to dim on long press? They only dim onDrag now, somewhat tricky to see that it's "now" if only the item under your finger changes.

Sometimes I end up with an empty space the size of an item that... Sometimes moves around, sometimes not. Dragging *inside* the launcher seems to be the easiest to reproduce.

I'd be OK with merging this if you say these should be fixed at a later iteration, though.

review: Needs Information

« Back to merge proposal