Code review comment for lp:~mzanetti/unity8/dnd-and-quicklists
Revision history for this message
| Michael Zanetti (mzanetti) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4d1350f
(Get the code!)
> > There's some jerkiness when going back from expanded state, the folded items
> > jump into place - especially if you drop the item in a place where it will
> > become folded. Either we should scroll more (so that the item isn't folded
> > after dropping) or maybe delay the folding... Or something...
>
>
> This is the same bug as the initial folded item. Should be fixed once we
> manage to patch the ListView in upstream Qt.
Right... there's another issue. By the time the transition from "expanded" to "" is triggered, the item is still closer to the center, which means less folding. Apparently the target angle gets calculated for this position, e.g. 18°. Now, while it folds to that target angle it gets also moved towards the end because of the dropped item is expanding. Being towards closer to the edge means that now it would need to fold to 53° instead of only 18° though. Once the folding transition to 18° is done, it updates again to the new target angle which causes the jump. Need to figure a solution.