Code review comment for lp:~mzanetti/unity8/dash-as-app
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Repeating as the inline comments don't work so well.
In SpreadDelegate.qml
"""
1114 + objectName: "surfaceContainer" + index
"""
Using index from inside SpreadDelegate breaks encapsulation. You can achive the same result in tst_Shell.qml by fetching first "appDelegate0" and then fecthing the "surfaceContainer" from within "appDelegate0".