Code review comment for lp:~mzanetti/unity8/alerting-pips

Revision history for this message
Michael Zanetti (mzanetti) wrote :

 * Are there any related MPs required for this MP to build/function as expected? Please list.

yes, listing them in a minute

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

yes

 * If you changed the UI, has there been a design review?

yes, change requested by design. This reveals an issue in the design spec. Here's my conversation with John:

<mzanetti> I have a small issue with the persistent alert state
 we are currently coloring pips blue. Problem is, if the app is not running and the alert happened because of a push notification, there is no pip which could be blue
 the count emblem will still be there though
<JohnLea> humm, yes this is a small problem
 I think it is ok for the moment, but a better solution could be to use something else as the persistent alert notification
<mzanetti> you tell me: a) ignore the problem or b) force a pip even if no surface
<JohnLea> for now do a)
<mzanetti> ack
<JohnLea> in the mean time I'll speak to Matthieu and ask him to have a look at other options, perhaps indicating something on the app icon itself
 but that's for the future

« Back to merge proposal