1
=== added directory '.bazaar'
2
=== added file '.bazaar/Makefile'
3
--- .bazaar/Makefile	1970-01-01 00:00:00 +0000
4
+++ .bazaar/Makefile	2013-04-05 08:27:22 +0000
5
@@ -0,0 +1,6 @@
6
1
install:
7
2
	mkdir -p ~/.bazaar/plugins
8
3
	cp plugins/* ~/.bazaar/plugins
9
4
10
5
uninstall:
11
6
	rm ~/.bazaar/plugins/makecheck_unity_phablet.py*
12
0
7
13
=== added directory '.bazaar/plugins'
14
=== added file '.bazaar/plugins/makecheck_unity_phablet.py'
15
--- .bazaar/plugins/makecheck_unity_phablet.py	1970-01-01 00:00:00 +0000
16
+++ .bazaar/plugins/makecheck_unity_phablet.py	2013-04-05 08:27:22 +0000
17
@@ -0,0 +1,34 @@
18
1
#!/usr/bin/python
19
2
# Copyright 2013 Canonical Ltd.
20
3
#
21
4
# This program is free software; you can redistribute it and/or modify
22
5
# it under the terms of the GNU Lesser General Public License as published by
23
6
# the Free Software Foundation; version 3.
24
7
#
25
8
# This program is distributed in the hope that it will be useful,
26
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
27
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
28
11
# GNU Lesser General Public License for more details.
29
12
#
30
13
# You should have received a copy of the GNU Lesser General Public License
31
14
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
32
15
33
16
import os, subprocess
34
17
from bzrlib import branch, errors
35
18
from bzrlib.urlutils import dirname, local_path_from_url
36
19
37
20
def execute_makecheck(local_branch, master_branch, old_revision_number, old_revision_id, future_revision_number, future_revision_id, tree_delta, future_tree):
38
21
    if not master_branch.basis_tree().has_filename("Shell.qml"):
39
22
        return
40
23
41
24
    os.chdir(local_path_from_url(master_branch.base))
42
25
43
26
    print "Executing 'make check'.."
44
27
    if (subprocess.call("make check", shell=True) != 0):
45
28
        raise errors.BzrError("Unit tests failed, fix them before committing!")
46
29
47
30
    print "Executing 'make qmluitests'.."
48
31
    if (subprocess.call("make qmluitests", shell=True) != 0):
49
32
        raise errors.BzrError("QML UI tests failed, fix them before committing!")
50
33
51
34
branch.Branch.hooks.install_named_hook('pre_commit', execute_makecheck, 'make check pre-commit')
Status:	Merged
Approved by:	Albert Astals Cid on 2013-04-08
Approved revision:	no longer in the source branch.
Merged at revision:	548
Proposed branch:	lp:~mzanetti/unity/phablet-make-check-hook
Merge into:	lp:unity/phablet
Diff against target:	51 lines (+40/-0) 2 files modified .bazaar/Makefile (+6/-0) .bazaar/plugins/makecheck_unity_phablet.py (+34/-0)
To merge this branch:	bzr merge lp:~mzanetti/unity/phablet-make-check-hook
Related bugs:	Link a bug report
Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2013-04-05
Michał Sawicz			Needs Fixing on 2013-04-03
Albert Astals Cid (community)		2013-03-18	Approve on 2013-03-22
Review via email: mp+153868@code.launchpad.net