Code review comment for lp:~mzanetti/unity-api/surfaceCount-property

Revision history for this message
Albert Astals Cid (aacid) wrote :

I think it's just two different ways to approach how to implement the feature, and I can't mark one as better than the other.

Daniel has a point in that the list is documented to be a constant property so it won't disappear magically under your feet, but on the other hand you need an extra disconnect that is a bit uglier.

This is a nice philosophical discussion and makes for a nice bar+beer nerd-discussion.

BUT let's not forget we're here to make a product and that we need to be pragmatical and let's agree that the code written here is not so bad that it needs to be rewritten and cause another round of reviews + review fixes, which probably mean a day or more of work-time invested in something that will still give us a feature with the same level of quality and maintenance effort as we have now.

For that reason i'm just going to approve this MR.

Let's try to be a bit more pragmatical with the reviews and also take comments a bit less personally (i know it's hard, i'm the first to fail)

review: Approve

« Back to merge proposal