Code review comment for lp:~mzanetti/unity-api/application-api

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> + * @bried The currently focused application.
> Typo: "brief"

fixed.

>
> startProcess & stopProcess - sorry I just realized that the names are next
> exactly correct, as an application may launch several processes (e.g.
> webbrowser-app spawns a QWebProcess for each tab). Perhaps rename to just
> "start" and "stop", or "startApplication" and "stopApplication"

renamed to start/stopApplication

>
> Only other issue is in your tests, that "Ubuntu.Application" is not a clear
> name for the plugin. I'm using "Unity.ApplicationManager" in unity-mir which
> is hopefully more descriptive.

As discussed in IRC, renamed to Unity.Application.

« Back to merge proposal