I get the error that this MR fixes (without applying the changes proposed here) in a branch when I run 'make check' with Qt 5.0.2:
********* Start testing of components ********* Config: Using QTest library 5.0.2, Qt 5.0.2 PASS : components::UbuntuListView::initTestCase() PASS : components::UbuntuListView::test_collapseByClickingOutside() PASS : components::UbuntuListView::test_destroyAndRecreateExpanded() PASS : components::UbuntuListView::test_dimOthers() PASS : components::UbuntuListView::test_expandedItem() FAIL! : components::UbuntuListView::test_noScrollingNeeded() Compared values are not the same with delta(0.5) Actual (): -272.084628099174 Expected (): 48 Loc: [/home/tim/dev/ubuntu-ui-toolkit/tabsModelIndex/tests/unit_x11/tst_components/tst_ubuntulistview.qml(119)] PASS : components::UbuntuListView::test_scrollIntoView() FAIL! : components::UbuntuListView::test_scrollToTop() Compared values are not the same with delta(0.5) Actual (): -96.0846280991736 Expected (): 0 Loc: [/home/tim/dev/ubuntu-ui-toolkit/tabsModelIndex/tests/unit_x11/tst_components/tst_ubuntulistview.qml(131)] PASS : components::UbuntuListView::cleanupTestCase() Totals: 7 passed, 2 failed, 0 skipped ********* Finished testing of components *********
After merging lp:~mzanetti/ubuntu-ui-toolkit/more-stable-ubuntulistview-tests I didn't get the failure anymore, so the MR seems to fix the bug for Qt50 also.
« Back to merge proposal
I get the error that this MR fixes (without applying the changes proposed here) in a branch when I run 'make check' with Qt 5.0.2:
********* Start testing of components ********* :UbuntuListView ::initTestCase( ) :UbuntuListView ::test_ collapseByClick ingOutside( ) :UbuntuListView ::test_ destroyAndRecre ateExpanded( ) :UbuntuListView ::test_ dimOthers( ) :UbuntuListView ::test_ expandedItem( ) :UbuntuListView ::test_ noScrollingNeed ed() Compared values are not the same with delta(0.5) tim/dev/ ubuntu- ui-toolkit/ tabsModelIndex/ tests/unit_ x11/tst_ components/ tst_ubuntulistv iew.qml( 119)] :UbuntuListView ::test_ scrollIntoView( ) :UbuntuListView ::test_ scrollToTop( ) Compared values are not the same with delta(0.5) tim/dev/ ubuntu- ui-toolkit/ tabsModelIndex/ tests/unit_ x11/tst_ components/ tst_ubuntulistv iew.qml( 131)] :UbuntuListView ::cleanupTestCa se()
Config: Using QTest library 5.0.2, Qt 5.0.2
PASS : components:
PASS : components:
PASS : components:
PASS : components:
PASS : components:
FAIL! : components:
Actual (): -272.084628099174
Expected (): 48
Loc: [/home/
PASS : components:
FAIL! : components:
Actual (): -96.0846280991736
Expected (): 0
Loc: [/home/
PASS : components:
Totals: 7 passed, 2 failed, 0 skipped
********* Finished testing of components *********
After merging lp:~mzanetti/ubuntu-ui-toolkit/more-stable-ubuntulistview-tests I didn't get the failure anymore, so the MR seems to fix the bug for Qt50 also.