Code review comment for lp:~mzanetti/ubuntu-ui-toolkit/more-stable-ubuntulistview-tests

Revision history for this message
Tim Peeters (tpeeters) wrote :

I get the error that this MR fixes (without applying the changes proposed here) in a branch when I run 'make check' with Qt 5.0.2:

********* Start testing of components *********
Config: Using QTest library 5.0.2, Qt 5.0.2
PASS : components::UbuntuListView::initTestCase()
PASS : components::UbuntuListView::test_collapseByClickingOutside()
PASS : components::UbuntuListView::test_destroyAndRecreateExpanded()
PASS : components::UbuntuListView::test_dimOthers()
PASS : components::UbuntuListView::test_expandedItem()
FAIL! : components::UbuntuListView::test_noScrollingNeeded() Compared values are not the same with delta(0.5)
   Actual (): -272.084628099174
   Expected (): 48
   Loc: [/home/tim/dev/ubuntu-ui-toolkit/tabsModelIndex/tests/unit_x11/tst_components/tst_ubuntulistview.qml(119)]
PASS : components::UbuntuListView::test_scrollIntoView()
FAIL! : components::UbuntuListView::test_scrollToTop() Compared values are not the same with delta(0.5)
   Actual (): -96.0846280991736
   Expected (): 0
   Loc: [/home/tim/dev/ubuntu-ui-toolkit/tabsModelIndex/tests/unit_x11/tst_components/tst_ubuntulistview.qml(131)]
PASS : components::UbuntuListView::cleanupTestCase()
Totals: 7 passed, 2 failed, 0 skipped
********* Finished testing of components *********

After merging lp:~mzanetti/ubuntu-ui-toolkit/more-stable-ubuntulistview-tests I didn't get the failure anymore, so the MR seems to fix the bug for Qt50 also.

« Back to merge proposal