Code review comment for lp:~mzanetti/ubuntu-ui-toolkit/expandable-and-column

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Zsombor's feedback on the original MP:

> For ListItems.Expandable:
> - provide property which configures the possibility to collapse the Expandable while clicked on its "header"

done.

> - make sure design does not want a down/up pointing chevron to be shown which would indicate there is something more > to be shown (as in OptionSelector's case)

This really doesn't belong in here imo... Adding that here would make it unusable for everything except OptionSelector and ComboBox. This is really intended to handle the expansion pattern without dictating the users (as in developer) what he has to put inside of it.

« Back to merge proposal