Code review comment for lp:~mzanetti/ubuntu-clock-app/drop-audioRole

Revision history for this message
Jim Hodapp (jhodapp) wrote :

On Thu, Oct 22, 2015 at 4:12 PM, Michał Sawicz <email address hidden>
wrote:

> W dniu 22.10.2015 o 21:37, Jim Hodapp pisze:
> > I agree, but we are discussing only the alarm preview in this MR. Unless
> the actual alarm uses the same audio role as the preview does?
>
> No, but why would this be alert role, while the real alarm would be
> alarm role?
>

It wouldn't be, they'd be the same. I just don't believe it should be the
general video or music roles, which one of those will end up being the
default role to be equivalent to the old multimedia role.

>
> --
>
> https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179
> You are reviewing the proposed merge of
> lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app.
>

« Back to merge proposal