Code review comment for lp:~mzanetti/reminders-app/tablet

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Good work, I find only one error:
- Open a note in tablet mode
- Edit it
- Hide the toolbar
- The height of the side where you edit the note is < than the height of window, so there is some blank space...

Also, I noticed same strange behavior. They are corner cases and only for desktop, so if is difficult to fix them we can approve this branch as it is.

#1:
Start the app as phone size
Open a note
Expand the app to tablet mode
The note remains on little screen

#2:
Start the app as phone size
Expand the app to table mode
Open a void note (A note with title "Untitled" and no body)
Open another note.
The note opens in phone mode.

This is the output of terminal:
file:///home/rpadovani/Documents/ubuntu/touch/core-apps/tablet-build/src/app/qml/ui/NoteView.qml:40: TypeError: Cannot read property 'enmlContent' of undefined
file:///home/rpadovani/Documents/ubuntu/touch/core-apps/tablet-build/src/app/qml/ui/NoteView.qml:29: TypeError: Cannot read property 'title' of undefined
file:///home/rpadovani/Documents/ubuntu/touch/core-apps/tablet-build/src/app/qml/ui/NoteView.qml:72: TypeError: Cannot read property 'htmlContent' of undefined

review: Needs Fixing

« Back to merge proposal