Merge lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Zanetti
Approved revision: 431
Merged at revision: 432
Proposed branch: lp:~mzanetti/reminders-app/still-that-focus
Merge into: lp:reminders-app
Prerequisite: lp:~mzanetti/reminders-app/fix-renderwidth
Diff against target: 13 lines (+1/-1)
1 file modified
src/app/qml/ui/EditNoteView.qml (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/still-that-focus
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+258566@code.launchpad.net

This proposal supersedes a proposal from 2015-05-07.

Commit message

Fix 1452907

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:431
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mzanetti/reminders-app/still-that-focus/+merge/258566/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/740/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2722
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2722/artifact/work/output/*zip*/output.zip
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/342/console
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/162

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/740/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Fixes the issues, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/EditNoteView.qml'
2--- src/app/qml/ui/EditNoteView.qml 2015-05-07 21:46:21 +0000
3+++ src/app/qml/ui/EditNoteView.qml 2015-05-07 21:46:21 +0000
4@@ -629,8 +629,8 @@
5 text: i18n.tr("Done")
6 height: parent.height
7 iconColor: UbuntuColors.green
8- activeFocusOnPress: true
9 onClicked: {
10+ forceActiveFocus();
11 saveNote();
12 root.exitEditMode(root.note);
13 }

Subscribers

People subscribed via source and target branches