Merge lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app

Proposed by Michael Zanetti
Status: Superseded
Proposed branch: lp:~mzanetti/reminders-app/still-that-focus
Merge into: lp:reminders-app
Diff against target: 30 lines (+3/-2)
1 file modified
src/app/qml/ui/EditNoteView.qml (+3/-2)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/still-that-focus
Reviewer Review Type Date Requested Status
Ubuntu Notes app developers Pending
Review via email: mp+258565@code.launchpad.net

This proposal has been superseded by a proposal from 2015-05-07.

Commit message

do it manually.. AbstractButton is not clever enough...

To post a comment you must log in.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/EditNoteView.qml'
2--- src/app/qml/ui/EditNoteView.qml 2015-04-27 17:24:33 +0000
3+++ src/app/qml/ui/EditNoteView.qml 2015-05-07 21:45:06 +0000
4@@ -37,6 +37,7 @@
5 notebookSelector.selectedIndex = i;
6 }
7 }
8+ note.renderWidth = noteTextArea.width - noteTextArea.textMargin * 2
9 }
10
11 signal exitEditMode(var note)
12@@ -84,7 +85,7 @@
13 target: noteTextArea
14 onWidthChanged: {
15 note.richTextContent = noteTextArea.text;
16- note.renderWidth = noteTextArea.width - noteTextArea.textMargin
17+ note.renderWidth = noteTextArea.width - noteTextArea.textMargin * 2
18 }
19 }
20
21@@ -628,8 +629,8 @@
22 text: i18n.tr("Done")
23 height: parent.height
24 iconColor: UbuntuColors.green
25- activeFocusOnPress: true
26 onClicked: {
27+ forceActiveFocus();
28 saveNote();
29 root.exitEditMode(root.note);
30 }

Subscribers

People subscribed via source and target branches