Ubuntu Notes app

Code review comment for lp:~mzanetti/reminders-app/rework-error-handling

  1. rework-error-handling
  2. Merge into trunk
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> >> 1. In notes.h, I believe you'll want to include QQmlParserStatus in a
> >> Q_INTERFACES macro.
>
> > Hmm... Why is that?
>
> I'm not familiar with this, so take this as a pointer rather than an
> suggestion, but my guess would be as it's recommended at http://qt-
> project.org/doc/qt-5.0/qtqml/qqmlparserstatus.html
>
> In any case, I don't see this affecting this MP.

Oh... now I get it... Yeah. in this merge notes.h still inherits QQmlParserStatus. This has been changed in a newer one. If you want me I can add it in here for completeness, but it would be removed again with the next merge. Sorry for the confusion.

« Back to merge proposal