Code review comment for lp:~mzanetti/reminders-app/rework-error-handling

Revision history for this message
Victor Thompson (vthompson) wrote :

1. In notes.h, I believe you'll want to include QQmlParserStatus in a Q_INTERFACES macro.
2. I see you're reworking some of the connection error exception handling. I get the following core dump every so often, I wonder if it's related to an error that isn't being handled.

terminate called after throwing an instance of 'apache::thrift::transport::TSSLException'
  what(): SSL_write: errno = 110
Aborted (core dumped)

3. Overall the changes to job handling and error handling look good--is there any particular error path that's being fixed that I might be able to try to reproduce? It's a bit hard to try to verify an overall rework of exception handling.

review: Needs Information

« Back to merge proposal