Code review comment for lp:~mzanetti/reminders-app/notes-headers-to-trunk

Revision history for this message
David Planella (dpm) wrote :

82 + return createdDate.toString("MMMM yyyy");

Could we make this something along the lines of:

const QLocale l = QLocale::system();

return QString(gettext("%1 %2")).arg(l.standaloneMonthName(createdDate.month())).arg(createdDate.year());

The issue here is that the QDate formats don't work very well for all locales. So "MMMM" does not return the standalone month name in e.g. Catalan. I.e. instead of "gener" it returns "de gener" - the translation in English would be "January" vs. "of January"

review: Needs Fixing

« Back to merge proposal