Code review comment for lp:~mzanetti/reminders-app/new-edit-mode

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Wow. Just wow, this is an amazing work!

I left some comments, mainly questions about the code.

Also, there are two little behavior I think have to be fixed:

#Text format
- Write a plain text (e.g. 123789)
- Place the cursor in the middle (e.g. 123|789)
- Set a style (e.g. bold)
- Start writing (e.g. 123*45|*789)
- Press enter (e.g.123*45\n|*789)
- Write a new char (e.g 6)

Note that the new char doesn't follow the previous style.

Result: 123*45*\n6789
Expected result: 123*45\n6*789

#Horizontal line is broke
- Write a text, click on horizontal line without going on a new line, the text is deleted. I expect the text is saved and horizontal line is created on a new line
- Write a text, create a horizontal line, insert other text, save the note.
The text after the horizontal line isn't saved

« Back to merge proposal