Code review comment for lp:~mzanetti/reminders-app/integrate-plugin
Revision history for this message
| Michael Zanetti (mzanetti) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> 1) There is a typo in the reminders-app.qml file:
fixed.
> 2) This is simply a suggestion, but could we use something more generic to
> name the 3rdParty folder and project file? That is, could we use 'lib' instead
> of '3rdParty'?
Usually "lib" is used for libs that are part of this source code, i.e. if we would write it our own. 3rdParty indicates that this is really just imported without major modifications. So in my opinion keeping it to 3rdParty would be better. But if you guys agree this should be renamed to "lib" I can sure do that.