Code review comment for lp:~mzanetti/reminders-app/integrate-plugin

Revision history for this message
David Planella (dpm) wrote :

Excellent work, I could get it to fetch and render my notes. There are only a couple of minor things I noticed:

1) There is a typo in the reminders-app.qml file:

file:///tmp/build-reminders-app-Desktop-Debug/src/app/qml/reminders-app.qml:61:23: Reminders is not a type
                     page: Reminders {
                           ^
That needs to be RemindersPage

2) This is simply a suggestion, but could we use something more generic to name the 3rdParty folder and project file? That is, could we use 'lib' instead of '3rdParty'?

review: Needs Fixing

« Back to merge proposal