Code review comment for lp:~mzanetti/reminders-app/improve-viewer

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> [Tablet mode] Choose a note, then choose another note, the note preview goes
> over the header.

fixed

>
> You forgot to remove a reference to a componenent you delete:
> src/app/qml/ui/EditNoteView.qml:35: ReferenceError: notebookSelector is not
> defined

fixed.

>
> [Tablet mode] Cannot create a reminders: qml: pushing reminderspage false
> file:///home/rpadovani/Ubuntu/touch/core-apps/reminders/reminders-
> app/builddir/src/app/qml/ui/NoteView.qml:69: TypeError: Cannot call method
> 'push' of null

I sort of fixed it, it sucks quite a bit visually, but let's not try to make it perfect for tablet mode just yet and wait for the upcoming multicolumn Page Stack in the SDK.

>
> [Tablet mode] If the first note in the list isn't of the default notebook and
> you choose it, in the preview there is the notebook selector with the default
> notebook selected (I think is related to a diff comment I left)

fixed

« Back to merge proposal