Ubuntu Notes app

Code review comment for lp:~mzanetti/reminders-app/improve-viewer

  1. improve-viewer
  2. Merge into trunk
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

You forgot to edit connect signal in reminders.qml switching from opentaggednote to editnote:

(tablet mode)
file:///home/rpadovani/Ubuntu/touch/core-apps/reminders/reminders-app/builddir/src/app/qml/reminders.qml:146: TypeError: Cannot call method 'connect' of undefined

In phone mode I've this error: file:///home/rpadovani/Ubuntu/touch/core-apps/reminders/reminders-app/builddir/src/app/qml/ui/NoteView.qml:87: ReferenceError: offset is not defined

I cannot close notes in tablet mode:
file:///home/rpadovani/Ubuntu/touch/core-apps/reminders/reminders-app/builddir/src/app/qml/ui/NoteView.qml:158: TypeError: Cannot call method 'pop' of null

« Back to merge proposal