Merge lp:~mzanetti/reminders-app/fix-label-wrapping into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 474
Merged at revision: 475
Proposed branch: lp:~mzanetti/reminders-app/fix-label-wrapping
Merge into: lp:reminders-app
Diff against target: 32 lines (+3/-3)
2 files modified
src/app/qml/components/NotesDelegate.qml (+1/-1)
src/app/qml/components/RemindersDelegate.qml (+2/-2)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/fix-label-wrapping
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265887@code.launchpad.net

Commit message

fix label growing out of place

To post a comment you must log in.
474. By Michael Zanetti

also fix the remindersdelegate

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/qml/components/NotesDelegate.qml'
--- src/app/qml/components/NotesDelegate.qml 2015-06-14 23:34:29 +0000
+++ src/app/qml/components/NotesDelegate.qml 2015-07-25 02:42:13 +0000
@@ -137,7 +137,7 @@
137 text: "<font color=\"" + root.notebookColor + "\">" +137 text: "<font color=\"" + root.notebookColor + "\">" +
138 Qt.formatDateTime(root.date, Qt.LocalDate) +138 Qt.formatDateTime(root.date, Qt.LocalDate) +
139 " </font>" + root.content.replace("\n", " ").trim()139 " </font>" + root.content.replace("\n", " ").trim()
140 wrapMode: Text.WordWrap140 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
141 textFormat: Text.StyledText141 textFormat: Text.StyledText
142 maximumLineCount: 2142 maximumLineCount: 2
143 fontSize: "small"143 fontSize: "small"
144144
=== modified file 'src/app/qml/components/RemindersDelegate.qml'
--- src/app/qml/components/RemindersDelegate.qml 2015-03-15 20:00:21 +0000
+++ src/app/qml/components/RemindersDelegate.qml 2015-07-25 02:42:13 +0000
@@ -109,13 +109,13 @@
109 }109 }
110110
111 Label {111 Label {
112 text: note.tagline112 text: note.tagline.replace("\n", " ").trim()
113 fontSize: "small"113 fontSize: "small"
114 horizontalAlignment: Text.AlignLeft114 horizontalAlignment: Text.AlignLeft
115 Layout.fillWidth: true115 Layout.fillWidth: true
116 maximumLineCount: 2116 maximumLineCount: 2
117 width: parent.width117 width: parent.width
118 wrapMode: Text.WordWrap118 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
119 color: "black"119 color: "black"
120 }120 }
121 }121 }

Subscribers

People subscribed via source and target branches