Code review comment for lp:~mzanetti/reminders-app/edit-note-improvements

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> What a nice improvement :-)
>
> Cool, congrats!
>
> The only problem I found (but if you want we can fix in a later branch) is in
> the bottom edge: it's reported as notebook a random notebook, and not the one
> in which the note will be create.
>
> Just let me know if you want to fix later (and so I approve this) or you'll do
> it here

I've tried to fix that now but it's not as easy. It would require some reworking of how the bottom edge is created etc. Let's not do that until we have a clearer idea what will happen to the bottom edge in the convergenced world.

« Back to merge proposal