Ubuntu Notes app

Code review comment for lp:~mzanetti/reminders-app/cleanup-toolbars

  1. cleanup-toolbars
  2. Merge into trunk
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

> I still would keep the openAccountsPage() in reminders.qml because when there
> is no account set up, I want to push the AccountsPage to the stack, so the
> user can't switch to the other tabs.

Makes sense, but then you can drop the showBackButton property. If the AccountsPage is used only when there isn't any account set up, then the backButton is always hide (and you can simply hide it, and simplify the code about the backButton in the AccountPage).

review: Needs Fixing

« Back to merge proposal