Code review comment for mysql-packaging:mysql-5.7/rbasak/ubuntu/devel

"git diff --name-only import/5.7.17-0ubuntu1 pkg/ubuntu/devel -- debian" doesn't show innotop. So it wasn't part of the Ubuntu delta. That innotop is present in the version currently in Bionic ("old/ubuntu") is precisely because it isn't part of the Ubuntu delta.

Debian has indeed dropped it since, and that change is being picked up in the merge. We don't note changes being adopted from Debian in the merge changelog entry in an Ubuntu package merge, so I think this it is correct that I haven't explicitly mentioned it.

When this merge is uploaded to Ubuntu, a number of changelog entries will appear from the perspective of the user, with the top one being the merge changelog entry I've written (which doesn't mention innotop). In this set of new entries, one of the entries will be the 5.7.18-1 entry written for Debian which does explain that innotop is dropped. So from the perspective of the user, the change will have correctly been logged.

Since the Ubuntu delta didn't change anything with respect to innotop and after the merge the Ubuntu delta still doesn't change anything with respect to innotop. So nothing in the Ubuntu delta relates to innotop, and so it doesn't need to be mentioned in the Ubuntu package merge changelog entry.