Code review comment for lp:~mxsscott/widelands/windowed-graphics
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
>I'd love to have code review for my own stuff as well in the future. .... this kinda went offtopic of this merge - I'd like to hear the comments of everybody though!
+1
Code reviews are really nice as they can often reveal and resolve issues before they hit trunk. And if something breaks in the future, both the author and reviewer should be familiar with the code as opposed to only a single person.
One potential issue I see is of shortage of reviewers. We currently have nine branches waiting for review, some of which are quite old. On the other hand, some of those have raised issues which authors haven't addressed yet.
I think this would be worth a try. We can always re-assess later if we end up with lots of unmerged reviews and a trunk gathering dust.
And since this is completely off-topic, we should find some better place to discuss it; a forum thread, meta bug?