Code review comment for lp:~mxsscott/widelands/windowed-graphics

Revision history for this message
Mark Scott (mxsscott) wrote :

Reading right to left, it's a pointer to a const pointer to a const SDL_Rect.

const SDL_Rect** should also work because that's what SDL_ListModes() returns (we declare our variable to be more consty to indicate we don't mess with it.

The reason I left the init out of the for loop was due to line-length, but this is a pretty poor reason to do so.

I'll make these changes and re-push the branch.

I'm happy having trunk rights - but I do see the benefit of having code reviewed, especially where it is an area people are touching significantly or haven't touched before. Even if the coding is fine, there may be opportunity to say "Why don't you do this too?", or point out something that was missed "You left a todo in for function X's documentation" - we all forget these in the haste to commit before going away to do something else (sleep?)

« Back to merge proposal