Code review comment for lp:~mxsscott/widelands/clang

Revision history for this message
SirVer (sirver) wrote :

Ensure these macros so nothing for other compilers. -> typo: so should be do.
const char * & extension -> can you have a look if only the pointer or even better a const string& can be passed in here. reference to pointer looks fragile to me.
if (/* const Coords starting_pos = */map.get_starting_pos(m_plnum)) { -> you can just remove the variable here I think.

otherwise LGTM. Can you close the bug if this is appropriate now?

review: Needs Fixing

« Back to merge proposal