Merge ~mwhudson/ubuntu-cdimage:ubuntu-core-installer-publication into ubuntu-cdimage:main

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: eb71710bf2f8d3c00698ac8747c59f96d7048613
Proposed branch: ~mwhudson/ubuntu-cdimage:ubuntu-core-installer-publication
Merge into: ubuntu-cdimage:main
Diff against target: 75 lines (+17/-1)
2 files modified
lib/cdimage/tests/test_tree.py (+8/-0)
lib/cdimage/tree.py (+9/-1)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+467310@code.launchpad.net

Commit message

update tree.py to handle publication of ubuntu-core-installer images.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

could we get some corresponding tests please?

review: Needs Fixing
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Added some tests, is that enough?

Revision history for this message
Steve Langasek (vorlon) wrote :

LGTM thanks

review: Approve
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/cdimage/tests/test_tree.py b/lib/cdimage/tests/test_tree.py
index 63a5840..522229a 100644
--- a/lib/cdimage/tests/test_tree.py
+++ b/lib/cdimage/tests/test_tree.py
@@ -241,6 +241,8 @@ class TestPublisher(TestCase):
241 ("daily-live", "ubuntu-core", "bionic", "live-core"),241 ("daily-live", "ubuntu-core", "bionic", "live-core"),
242 ("daily-live", "ubuntu-core-desktop", "mantic",242 ("daily-live", "ubuntu-core-desktop", "mantic",
243 "live-core-desktop"),243 "live-core-desktop"),
244 ("daily-live", "ubuntu-core-installer", "noble",
245 "ubuntu-core-installer"),
244 ("daily", "ubuntu-base", "bionic", "base"),246 ("daily", "ubuntu-base", "bionic", "base"),
245 ("daily", "ubuntu-server", "bionic", "server"),247 ("daily", "ubuntu-server", "bionic", "server"),
246 ("daily", "ubuntu-server", "focal", "legacy-server"),248 ("daily", "ubuntu-server", "focal", "legacy-server"),
@@ -880,6 +882,12 @@ class TestDailyTreePublisher(TestCase):
880 "daily-live").publish_base)882 "daily-live").publish_base)
881 self.assertEqual(883 self.assertEqual(
882 os.path.join(884 os.path.join(
885 self.config.root, "www", "full", "ubuntu-core-installer",
886 "daily-live"),
887 self.make_publisher(
888 "ubuntu-core-installer", "daily-live").publish_base)
889 self.assertEqual(
890 os.path.join(
883 self.config.root, "www", "full", "kubuntu", "daily-live"),891 self.config.root, "www", "full", "kubuntu", "daily-live"),
884 self.make_publisher("kubuntu", "daily-live").publish_base)892 self.make_publisher("kubuntu", "daily-live").publish_base)
885 self.config["DIST"] = "hoary"893 self.config["DIST"] = "hoary"
diff --git a/lib/cdimage/tree.py b/lib/cdimage/tree.py
index 6fac63b..12a45e3 100644
--- a/lib/cdimage/tree.py
+++ b/lib/cdimage/tree.py
@@ -403,6 +403,8 @@ class Publisher:
403 return "netbook"403 return "netbook"
404 elif self.project == "ubuntu-server":404 elif self.project == "ubuntu-server":
405 return "live-server"405 return "live-server"
406 elif self.project == "ubuntu-core-installer":
407 return "ubuntu-core-installer"
406 elif self.project in ("ubuntu-core", "ubuntu-appliance"):408 elif self.project in ("ubuntu-core", "ubuntu-appliance"):
407 return "live-core"409 return "live-core"
408 elif self.project == "ubuntu-core-desktop":410 elif self.project == "ubuntu-core-desktop":
@@ -440,7 +442,7 @@ class Publisher:
440 elif publish_type in (442 elif publish_type in (
441 "desktop", "live", "netbook",443 "desktop", "live", "netbook",
442 "live-core", "live-core-desktop",444 "live-core", "live-core-desktop",
443 "live-server"):445 "live-server", "ubuntu-core-installer"):
444 return "daily-live"446 return "daily-live"
445 elif publish_type == "minimal":447 elif publish_type == "minimal":
446 return "daily-minimal"448 return "daily-minimal"
@@ -499,6 +501,8 @@ class Publisher:
499 return "Ubuntu Core %s" % cd501 return "Ubuntu Core %s" % cd
500 elif publish_type == "live-core-desktop":502 elif publish_type == "live-core-desktop":
501 return "Ubuntu Core Desktop %s" % cd503 return "Ubuntu Core Desktop %s" % cd
504 elif publish_type == "ubuntu-core-installer":
505 return "Ubuntu Core Installer %s" % cd
502 elif publish_type == "desktop":506 elif publish_type == "desktop":
503 return "desktop %s" % cd507 return "desktop %s" % cd
504 elif publish_type == "desktop-canary":508 elif publish_type == "desktop-canary":
@@ -758,6 +762,9 @@ class Publisher:
758 elif publish_type == "ubuntu-core-desktop":762 elif publish_type == "ubuntu-core-desktop":
759 sentences.append(763 sentences.append(
760 "Experimental Ubuntu Core Desktop installer images.")764 "Experimental Ubuntu Core Desktop installer images.")
765 elif publish_type == "ubuntu-core-installer":
766 sentences.append(
767 "Experimental installer for Ubuntu Core.")
761 elif publish_type == "ubuntu-appliance":768 elif publish_type == "ubuntu-appliance":
762 sentences.append(769 sentences.append(
763 "An Ubuntu Appliance turns a computer into a specialised "770 "An Ubuntu Appliance turns a computer into a specialised "
@@ -1127,6 +1134,7 @@ class Publisher:
1127 "preinstalled-core", "wubi",1134 "preinstalled-core", "wubi",
1128 "live-core",1135 "live-core",
1129 "live-core-desktop",1136 "live-core-desktop",
1137 "ubuntu-core-installer",
1130 "desktop-canary",1138 "desktop-canary",
1131 "desktop-legacy",1139 "desktop-legacy",
1132 )1140 )

Subscribers

People subscribed via source and target branches