Merge lp:~mwhudson/merge-o-matic/oops into lp:merge-o-matic

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 318
Proposed branch: lp:~mwhudson/merge-o-matic/oops
Merge into: lp:merge-o-matic
Diff against target: 22 lines (+3/-3)
1 file modified
produce-merges.py (+3/-3)
To merge this branch: bzr merge lp:~mwhudson/merge-o-matic/oops
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+355485@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'produce-merges.py'
--- produce-merges.py 2018-09-20 08:51:34 +0000
+++ produce-merges.py 2018-09-21 09:40:30 +0000
@@ -600,15 +600,15 @@
600 # between the ugo exec bits because it's hard to think of a reason we600 # between the ugo exec bits because it's hard to think of a reason we
601 # should.601 # should.
602 mode = 0o644602 mode = 0o644
603 if stat.S_IMODE(base_stat) & 0o111:603 if stat.S_IMODE(base_stat.st_mode) & 0o111:
604 # If base was executable and both left and right are, make output604 # If base was executable and both left and right are, make output
605 # executable.605 # executable.
606 if stat.S_IMODE(right_stat) & stat.S_IMODE(left_stat) & 0o111:606 if stat.S_IMODE(right_stat.st_mode) & stat.S_IMODE(left_stat.st_mode) & 0o111:
607 mode |= 0o111607 mode |= 0o111
608 else:608 else:
609 # Alternatively, if base was not executable and either of left and right609 # Alternatively, if base was not executable and either of left and right
610 # are, make output executable.610 # are, make output executable.
611 if (stat.S_IMODE(right_stat) | stat.S_IMODE(left_stat)) & 0o111:611 if (stat.S_IMODE(right_stat.st_mode) | stat.S_IMODE(left_stat.st_mode)) & 0o111:
612 mode |= 0o111612 mode |= 0o111
613613
614 with open(dest, "w", mode) as output:614 with open(dest, "w", mode) as output:

Subscribers

People subscribed via source and target branches

to status/vote changes: