Code review comment for lp:~mwhudson/loggerhead/unified-by-default-sbs-by-ajax

I'm going to merge this now.

Martin Albisetti wrote:
> On Thu, Feb 19, 2009 at 7:02 PM, Michael Hudson
> <email address hidden> wrote:
>>> * I guess this means we're going back to unified as the default. Is that intentional?
>> Semi... it's less processing client side to generate unified diffs. Maybe we should store the users last choice in a cookie and maybe change to sbs on domready?
>
> Cookies would be ideal, yes :)

File a bug? :)

>
>>> * What do you think about moving the added/removed color explanations to the line below it, and
>>> maybe float:right?
>> I don't understand this suggestion, I'm afraid.
>
> Do you know those squares that let you know which color is what, to
> the right of the link to swap unified/sbs? Those :)

OK, I knew what you meant, but not what you meant to do with them..

>>> * With big diffs, it makes the browser sweat quite a bit. Maybe we should not allow this madness
>>> with big-ish diffs?
>> What's big-ish? I was vaguely thinking that a progress bar might be good, but that might be over complicated...
>
> I don't think we can have a progress bar, it's basically the browser
> trying to do a lot and trying not to die.
> big-ish is ~4k lines

File another bug? :)

Cheers,
mwh