Code review comment for lp:~mwhudson/loggerhead/unified-by-default-sbs-by-ajax
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Thanks for keep on bringing awesomeness into loggerhead.
Glad you like it!
> I have a few non-blocking comments and open questions:
> * What about making the line number columns slightly tinted with red/green so you can link what
> they're related to better?
Good idea. r287 of the branch.
> * I guess this means we're going back to unified as the default. Is that intentional?
Semi... it's less processing client side to generate unified diffs. Maybe we should store the users last choice in a cookie and maybe change to sbs on domready?
> * What do you think about moving the added/removed color explanations to the line below it, and
> maybe float:right?
I don't understand this suggestion, I'm afraid.
> * With big diffs, it makes the browser sweat quite a bit. Maybe we should not allow this madness
> with big-ish diffs?
What's big-ish? I was vaguely thinking that a progress bar might be good, but that might be over complicated...