Hi Michael,
This looks very good, I really appreciate the cleanup, and it looks good to merge.
Just one question:
> === modified file 'loggerhead/controllers/inventory_ui.py' > @@ -85,7 +141,7 @@ > . > change = history.get_changes([ revid ])[0] > # If we're looking at the tip, use head: in the URL instead > - if revid == history.last_revid: > + if revid == branch.last_revision():
Isn't "revision" a little ambiguous? Or are we going to assume revision == revid, and revno == revno?
« Back to merge proposal
Hi Michael,
This looks very good, I really appreciate the cleanup, and it looks good to merge.
Just one question:
> === modified file 'loggerhead/ controllers/ inventory_ ui.py' get_changes( [ revid ])[0] last_revision( ):
> @@ -85,7 +141,7 @@
> .
> change = history.
> # If we're looking at the tip, use head: in the URL instead
> - if revid == history.last_revid:
> + if revid == branch.
Isn't "revision" a little ambiguous? Or are we going to assume revision == revid, and revno == revno?