Code review comment for lp:~mwhudson/loggerhead/ajaxy-revision-page

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hi Reviewer,

The main change this branch makes is to make the default revision page not show any diffs by default and having them loaded by the wonders of xhr.

I've put some effort in to making sure non-js users have a decent experience -- instead of xhr-ing a diff, when scripting is disabled the user is taken to a page that just contains the the diff for the file.

The code, particularly in revision_ui.py, is now much less than clear. I'll fix that in the next branch tomorrow -- basically if you think the new behaviour is good, I can then clean up the innards without changing behaviour tomorrow (perhaps it would have been better to clean up the innards then clean up the behaviour, but oh well).

« Back to merge proposal