Code review comment for lp:~mwhudson/livecd-rootfs/casper-be-gone

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

> I'm worried about not installing live-config as would normally be done in
> lb_chroot_live-packages (which is what you disabled by adding the touch
> command).

Nah, that bit of chroot_live-packages didn't fire (I guess we don't set LB_INITSYSTEM?)

> I have no idea if it's actually all that useful on our live images, but live-
> config is meant to do some late-boot "configuration" of the system, such as
> messing with sudoers, locale-gen, timezone, etc. for the live session. I just
> don't recall explicitly noticing that it was live-config rather than casper
> doing that work.

You can see that live-config is not installed in the manifest of the current livefs builds.

« Back to merge proposal