Code review comment for lp:~mwhudson/libmemcached/misc-memaslap-fixes

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Brian Aker <email address hidden> writes:

> Why did you comment out -Wunsuffixed-float-constants?

Because putting 'd' after all the floating point constants seemed really
tedious and the syntax is only supported by relatively new versions of
gcc (gcc.gnu.org/bugzilla/show_bug.cgi?id=39027 -- well, 4.5, I guess
that's fairly old now).

FWIW, memaslap contains the only floaing point constants in the entire
codebase, as far as I could tell.

Cheers,
mwh

« Back to merge proposal