On 22 March 2011 18:46, Michael Hudson-Doyle <email address hidden> wrote:
> On Tue, 22 Mar 2011 10:34:26 -0000, Graham Binns <email address hidden> wrote:
>> Review: Approve code
>> Hi Michael:
>>
>> 37 +##SRC_DIR = pkg_resources.resource_filename(
>> 38 +## pkg_resources.Requirement.parse("lazr-js"), "lazrjs")
>>
>> Does this still need to be in the code?
>
> No, clearly :-) Removing.
>
>> Other than that, this is r=me.
>
> Cool. Do I just land via PQM?, do you know?
Ffff. I *think* it's a PQM thing, yes. I've landed entirely one
lazr-js branch in the last six months, so I'm a bit rusty. Submit it
anyway and see what happens.
On 22 March 2011 18:46, Michael Hudson-Doyle <email address hidden> wrote: resource_ filename( Requirement. parse(" lazr-js" ), "lazrjs")
> On Tue, 22 Mar 2011 10:34:26 -0000, Graham Binns <email address hidden> wrote:
>> Review: Approve code
>> Hi Michael:
>>
>> 37 +##SRC_DIR = pkg_resources.
>> 38 +## pkg_resources.
>>
>> Does this still need to be in the code?
>
> No, clearly :-) Removing.
>
>> Other than that, this is r=me.
>
> Cool. Do I just land via PQM?, do you know?
Ffff. I *think* it's a PQM thing, yes. I've landed entirely one
lazr-js branch in the last six months, so I'm a bit rusty. Submit it
anyway and see what happens.